Use rtools40 for R >= 4.0 #85
Conversation
Codecov Report
@@ Coverage Diff @@
## master #85 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 1 1
=========================================
Hits 1 1 Continue to review full report at Codecov.
|
|
I tested this out, it seems to be working fine, though I do get a warning from
Hopefully we can get R CMD check to whitelist this flag before R 4.0 is released if it is necessary for Rtools40? Anyway the changes seem fine, thanks for sending the PR! |
…ed to guess & specify the rtools version
|
Hi @jeroen, Thanks for doing this! From looking at eea59e7#diff-78c52b4ebcf50fd32bb306df7f1a5b7cR10 it seems to me that if the R version is specified as a string ( Best, |
|
Why would it fail? Version |
|
You are right! But it would fail for |
|
I don't think such aliases are supported: #26 (comment) |
…tools-version number r-lib/actions#85 (comment). Also the code I wrote never specifies 'release' as the r-version. See also r-lib/actions#26 (comment) that Jeroen linked to.
|
Awesome, thanks for helping me understand this! Best, |
Created both an introductory and a developer's notes vignette, updated README and docs with examples, added a second biocViews term, fixed some small bugs/typos. Related links (as many as I could remember): * https://rstd.io/tidytools19 * https://twitter.com/CVWickham * https://twitter.com/hadleywickham * https://www.rstudio.com/products/rstudio/download * https://comunidadbioinfo.github.io/post/building-tidy-tools-cdsb-runconf-2019/#.XrbLMxNKiu4 * http://bioconductor.org/ * https://lcolladotor.github.io/pkgs/ * https://stat.ethz.ch/pipermail/bioc-devel/2020-March/016365.html * https://www.bioconductor.org/help/docker/ * https://stat.ethz.ch/pipermail/bioc-devel/2020-April/016532.html * https://github.com/features/actions * https://stat.ethz.ch/pipermail/bioc-devel/2020-April/016650.html * r-lib/actions#84 * r-lib/usethis#1108 * r-lib/styler#636 * Bioconductor/BiocCheck#57 * Bioconductor/bioconductor.org#54 * http://bioconductor.org/developers/how-to/coding-style/ * https://style.tidyverse.org/ * https://twitter.com/lorenzwalthert * https://twitter.com/mt_morgan * https://docs.travis-ci.com/user/languages/r/ * r-lib/pkgdown#1206 * r-lib/pkgdown#1230 * https://twitter.com/jimhester_ * https://www.jimhester.com/talk/2020-rsc-github-actions/ * https://github.com/Bioconductor/BBS * https://github.com/Bioconductor/packagebuilder * https://www.appveyor.com/ * r-hub/rhub#52 * r-hub/rhub#38 * https://www.tidyverse.org/blog/2020/04/usethis-1-6-0/ * https://github.com/r-lib/actions/tree/master/examples * https://yihui.org/en/2018/03/second-pull-request/ * https://github.com/r-lib/actions/blob/master/examples/check-standard.yaml * https://help.github.com/en/actions * https://ropenscilabs.github.io/actions_sandbox/ * https://twitter.com/seandavis12 * https://github.com/seandavi/BiocActions/blob/master/.github/workflows/main.yml * https://twitter.com/CSoneson * https://github.com/csoneson/dreval/blob/master/.github/workflows/R-CMD-check.yaml * https://bioc-community.herokuapp.com/ * https://github.com/leekgroup/derfinderPlot/blob/master/.github/workflows/check-bioc.yml * https://github.com/LieberInstitute/recount3/blob/master/.github/workflows/check-bioc.yml * https://github.com/hpages * r-lib/actions#68 * r-lib/actions#85 * https://twitter.com/opencpu * https://community.rstudio.com/u/const-ae * https://community.rstudio.com/t/compiler-support-fo-c-14-features-on-windows/57284/4 * r-lib/xml2#296 * r-lib/xml2#302 * https://github.com/r-lib/usethis/blob/master/.github/workflows/R-CMD-check.yaml * https://github.com/r-lib/usethis/commits/master/.github/workflows/R-CMD-check.yaml * https://stat.ethz.ch/pipermail/bioc-devel/2020-April/016703.html * https://stat.ethz.ch/pipermail/bioc-devel/2020-April/thread.html * r-lib/remotes#296 * r-lib/actions#86 * r-lib/covr#427 * https://github.com/r-lib/actions/blob/master/examples/pr-commands.yaml * https://www.digitalocean.com/community/tutorials/how-to-install-git-on-ubuntu-18-04 * r-lib/actions#50 * actions/checkout#238 * https://github.com/rocker-org/rocker-versioned2/blob/master/dockerfiles/Dockerfile_rstudio_4.0.0-ubuntu18.04 * https://twitter.com/niteshturaga * https://twitter.com/cboettig * rocker-org/rocker-versioned#208 * https://github.community/t5/GitHub-Actions/bd-p/actions * https://www.r-consortium.org/blog/2020/03/18/cdsb-diversity-and-outreach-hotspot-in-mexico * https://github.com/maxheld83 * r-lib/actions#87 * https://github.com/yutannihilation
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue and include a link to this pull request. |
Match the default CRAN toolchain, which now uses rtools40 for R 4.0 and R-devel.
The logic is that if
r-versionstarts with3(for example 3.6 or 3.x) then the default is rtools35. Otherwise (for example4.0ordevel) we need to install rtools40.We can tweak this more later, but for now this will suffice to start testing with R-devel (and soon R-4.0).