release() warns if NEWS.Rd exists #1135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| news_rd_path <- file.path(pkg$path, "inst/NEWS.Rd") | ||
| check_status( | ||
| !file.exists(news_rd_path), | ||
| "NEWS.Rd removed", |
There was a problem hiding this comment.
"NEWS.Rd does not exist" would be a better message, I think.
Also this is going to be a false positive for people who use inst/NEWS.Rd only
|
Changed error message, added pending NEWS. This check is invoked only if NEWS.md exists. |
| @@ -1,5 +1,11 @@ | |||
| # devtools 1.10.0.9000 | |||
|
|
|||
| * `release()` warns if both `inst/NEWS.Rd` and `NEWS.md` exist (@krlmlr, #1135). | |||
|
|
|||
| * `release()` doesn't throw error if Git head is detached (@krlmlr, #1136). | |||
There was a problem hiding this comment.
Where did these come from? Can I ignore?
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1133.