New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release() warns if NEWS.Rd exists #1135

Merged
merged 3 commits into from Apr 11, 2016

Conversation

Projects
None yet
2 participants
@krlmlr
Member

krlmlr commented Mar 27, 2016

Fixes #1133.

news_rd_path <- file.path(pkg$path, "inst/NEWS.Rd")
check_status(
!file.exists(news_rd_path),
"NEWS.Rd removed",

This comment has been minimized.

@hadley

hadley Mar 28, 2016

Member

"NEWS.Rd does not exist" would be a better message, I think.

Also this is going to be a false positive for people who use inst/NEWS.Rd only

@krlmlr

This comment has been minimized.

Member

krlmlr commented Mar 28, 2016

Changed error message, added pending NEWS. This check is invoked only if NEWS.md exists.

NEWS.md Outdated
@@ -1,5 +1,11 @@
# devtools 1.10.0.9000
* `release()` warns if both `inst/NEWS.Rd` and `NEWS.md` exist (@krlmlr, #1135).
* `release()` doesn't throw error if Git head is detached (@krlmlr, #1136).

This comment has been minimized.

@hadley

hadley Apr 11, 2016

Member

Where did these come from? Can I ignore?

This comment has been minimized.

@krlmlr

krlmlr Apr 11, 2016

Member

These are good I think -- already merged (#1124, #1136) but didn't have NEWS.

Kirill Müller added some commits Mar 27, 2016

@hadley hadley merged commit 8d50fe4 into r-lib:master Apr 11, 2016

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@hadley

This comment has been minimized.

Member

hadley commented Apr 11, 2016

Thanks!

@krlmlr krlmlr deleted the krlmlr:feature/1133-NEWS.Rd branch Oct 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment