Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release() warns if NEWS.Rd exists #1135

Merged
merged 3 commits into from Apr 11, 2016
Merged

release() warns if NEWS.Rd exists #1135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a6ae54c
warn if NEWS.Rd exists
Mar 27, 2016
f0e0ab0
better error message
Mar 28, 2016
a5a7d64
NEWS.md
Mar 28, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions NEWS.md
View file
Open in desktop
Expand Up @@ -8,6 +8,12 @@
* `create_description()` now sets `Encoding: UTF-8`. This helps non-English
package authors (#1123).

* `release()` warns if both `inst/NEWS.Rd` and `NEWS.md` exist (@krlmlr, #1135).

* `release()` doesn't throw error if Git head is detached (@krlmlr, #1136).

* `use_cran_badge()` now uses HTTPS URL (@krlmlr, #1124).

* `uses_github()` now confirms that you've picked a good title and description
(#1092).

Expand Down
7 changes: 7 additions & 0 deletions R/check-devtools.r
View file
Open in desktop
Expand Up @@ -98,6 +98,13 @@ check_news_md <- function(pkg) {
"NEWS.md is not ignored",
"NEWS.md now supported by CRAN and doesn't need to be ignored."
)

news_rd_path <- file.path(pkg$path, "inst/NEWS.Rd")
check_status(
!file.exists(news_rd_path),
"NEWS.Rd does not exist",
"NEWS.md now supported by CRAN, NEWS.Rd can be removed."
)
}

check_remotes <- function(pkg) {
Expand Down