Allow update_packages() prompt to be overridden #1261
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it would be better to test if |
pkq
force-pushed
the
update_packages-override
branch
2 times, most recently
from
38ec24a
to
ab514c1
Compare
|
Is this what you had in mind? |
pkq
force-pushed
the
update_packages-override
branch
from
f4e50e2
to
f084d64
Compare
pkq
force-pushed
the
update_packages-override
branch
from
f084d64
to
17bab48
Compare
|
I've cleaned this pull request up a bit, PTAL. Any guidance regarding testing is appreciated. Thanks! |
|
Thanks! Merged in aa5d4da |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on ticket #1260, this PR adds the ability to use
update_packages()non-interactively by adding anoverrideargument (i.e.,override = TRUE). Currently,calling update_packages()without a list of packages prompts the user to confirm the updates - this PR allows the user to override this prompt.FYI, I did read guidelines for contributing, as requested, but wasn't sure how or where to add a test for this.
Thanks.