Source single file gist without filename; fixes #1266 #1268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue in which an attempt to source a gist containing a single filename, but without specifying that filename, fails. Fixes issue #1266.
|
The issue page /issues/1266 seems to indicate this has been fixed, but I'm getting the same error as @Cauchy2. I've updated devtools and attempted to call gist_source() but to no avail. I'm a bit of a novice with this stuff so apologies in advance if i'm missing something simple! |
hadley
reviewed
Nov 3, 2016
| @@ -137,8 +137,8 @@ find_gist <- function(id, filename) { | |||
| } | |||
|
|
|||
| } else { | |||
| if (length(r_files) > 1) { | |||
| warning("Multiple R files in gist, using first.") | |||
| if (length(r_files) >= 1) { | |||
There was a problem hiding this comment.
This is rather confusing logic. I think it would be better as:
if (length(r_files) == 1) {
...
} else {
...
}
Presumably zero files should also be an error.
There was a problem hiding this comment.
Fair enough. I'll adjust accordingly. You already exit with an error when length(r_files) == 0 so no additional modification is necessary. Thanks!
hadley
reviewed
Nov 4, 2016
| @@ -137,7 +137,9 @@ find_gist <- function(id, filename) { | |||
| } | |||
|
|
|||
| } else { | |||
| if (length(r_files) > 1) { | |||
| if (length(r_files) = 1) { | |||
|
Of course. Thanks for your patience... |
|
Sorry, I forgot about your PR and ended up fixing by hand. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue in which an attempt to source a gist containing a single filename, but without specifying that filename, fails. Fixes issue #1266.