Pass R_CONFIGURE_FLAGS when configuring libuv #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
|
How is it possible that the PR builds fine on macOS, but after merging the build fails? |
|
That's so weird. I synced the fork at r-wasm/fs, and it passed there! Does it pass if you re-run the action? |
|
Yeah, re-run works. Probably some issue with the config of that runner. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the build fails when cross compiling for wasm or macos, because autoconf wants to get a
--hostflag. See for example build logs here: https://github.com/r-universe/r-lib/actions/runs/7467210469/job/20320359273I think the easiest solution is to use the same flags as we use for R
configurescripts.An alternative would be to introduce a new variable to specifically set the
--hostvariable, but I think this just introduces needless complexity. The libuv configure seems to ignore arguments that it does not know, so if R_CONFIGURE_FLAGS would contain additional parameters on some platforms, that should not matter either.@georgestagg @tylfin