Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lubridate here conflict #43

Merged
merged 3 commits into from
Feb 12, 2020
Merged

Conversation

nzgwynn
Copy link
Contributor

@nzgwynn nzgwynn commented Jan 31, 2020

Closes #37. Update documentation to address conflict with lubridate::here.

@codecov-io
Copy link

codecov-io commented Jan 31, 2020

Codecov Report

Merging #43 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #43   +/-   ##
=======================================
  Coverage   11.11%   11.11%           
=======================================
  Files           4        4           
  Lines          36       36           
=======================================
  Hits            4        4           
  Misses         32       32

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42901f9...9492c14. Read the comment docs.

R/here.R Outdated
@@ -5,6 +5,10 @@
#' Use it as a drop-in replacement for [file.path()], it will always locate the
#' files relative to your project root.
#'
#' If you see `Error in here("data", "df.rda") : unused arguments ("data",
#' "df.rda")"`, you may have attached \pkg{lubridate} after \pkg{here}.
#' Correct this using \pkg{conflicts} or, here::here("data", "df.rda").
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\pkg{conflicts} -> \pkg{conflicted} and redocument

@krlmlr krlmlr merged commit a3ab1d0 into r-lib:master Feb 12, 2020
@krlmlr
Copy link
Member

krlmlr commented Feb 12, 2020

Thanks!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conflict with lubridate::here()
4 participants