Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor deprecation functions #83

Merged
merged 10 commits into from
Jan 11, 2021
Merged

Refactor deprecation functions #83

merged 10 commits into from
Jan 11, 2021

Conversation

hadley
Copy link
Member

@hadley hadley commented Jan 11, 2021

So that the message is only ever generated once. I think this makes the overall logic a little easier to follow, and will make it easier to add support for unquoted what and with.

So that the message is only ever generated once. I think this makes the overall logic a little easier to follow, and will make it easier to add support for unquoted what and with.
@hadley hadley requested a review from lionel- January 11, 2021 15:39
@hadley
Copy link
Member Author

hadley commented Jan 11, 2021

Also need to incorporate #47

Copy link
Member

@lionel- lionel- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@hadley hadley merged commit 3fc3adc into master Jan 11, 2021
@hadley hadley deleted the deprecated-refactor branch January 11, 2021 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants