Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sprintf_linter causes test warning on r-devel #624

Closed
AshesITR opened this issue Nov 29, 2020 · 0 comments · Fixed by #625
Closed

sprintf_linter causes test warning on r-devel #624

AshesITR opened this issue Nov 29, 2020 · 0 comments · Fixed by #625

Comments

@AshesITR
Copy link
Collaborator

https://travis-ci.org/github/jimhester/lintr/jobs/746547257#L1728

── Warning (test-sprintf_linter.R:7:3): returns the correct linting ────────────

one argument not used by format 'hello'

── Warning (test-sprintf_linter.R:43:3): returns the correct linting ───────────

one argument not used by format 'hello %1$s %s'

── Warning (test-sprintf_linter.R:47:3): returns the correct linting ───────────

one argument not used by format 'hello %1$s %1$s'

Should catch the warning in the linter using withCallingHandlers and turn it into a lint.
AshesITR added a commit that referenced this issue Nov 29, 2020
@AshesITR
Make sprintf_linter capture warnings
158ef97 
fixes #624
@AshesITR AshesITR mentioned this issue Nov 29, 2020
Merged
AshesITR added a commit that referenced this issue Nov 29, 2020
@AshesITR
Make sprintf_linter capture warnings (#625)
f5b4750 
* Make sprintf_linter capture warnings

fixes #624

* speculative test update & update NEWS.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make sprintf_linter capture warnings r-lib/lintr
1 participant
@AshesITR