Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress bars are broken with dev cli #210

Closed
gaborcsardi opened this issue Oct 20, 2020 · 2 comments · Fixed by #212
Closed

Progress bars are broken with dev cli #210

gaborcsardi opened this issue Oct 20, 2020 · 2 comments · Fixed by #212

Comments

@gaborcsardi
Copy link
Member

Which we are using now, because pkgdepends requests it:

❯ pak::pkg_install("r-lib/pkgdepends")
Checking 12 metadata files
⠋ Updating metadata [0/12] | Downloading [0 B / 0 B]
⠙ Updating metadata [2/12] | Downloading [0 B / 0 B]
⠹ Updating metadata [3/12] | Downloading [13.42 kB / 13.42 kB]
⠸ Updating metadata [5/12] | Downloading [20.13 kB / 20.13 kB]
⠼ Updating metadata [8/12] | Downloading [6.71 kB / 6.71 kB]
⠴ Updating metadata [10/12] | Downloading [0 B / 0 B]
⠦ Updating metadata [10/12] | Downloading [0 B / 0 B]
⠧ Updating metadata [10/12] | Downloading [0 B / 0 B]
✔ Updated metadata: 0 B in 2 files.


 Found  1  deps for  0/1  pkgs [⠋] Resolving r-lib/pkgdepends
 Found  1  deps for  0/1  pkgs [⠙] Resolving r-lib/pkgdepends
 Found  1  deps for  0/1  pkgs [⠹] Resolving r-lib/pkgdepends
 Found  1  deps for  0/1  pkgs [⠸] Resolving r-lib/pkgdepends
 Found  22  deps for  1/1  pkgs [⠼] Resolving r-lib/cli
 Found  25  deps for  1/1  pkgs [⠴] Resolving r-lib/cli
 Found  59  deps for  1/1  pkgs [⠦] Resolving r-lib/cli
 Found  77  deps for  1/1  pkgs [⠧] Resolving r-lib/cli
→ All 0 packages (0 B) are cached.
ℹ No downloads are needed
@jimhester
Copy link
Member

jimhester commented Oct 20, 2020

This seems to be because the dynamic tty detection needs to be done in the main pak process and passed down to the subprocess, but unfortunately that is not easy to do without loading cli in the main process...

@jimhester
Copy link
Member

jimhester commented Oct 20, 2020

I guess we could put the stuff in rstudio-detect and tty in standalone files...

jimhester added a commit that referenced this issue Oct 20, 2020
With the unfortunate side effect of loading cli and its dependencies

Fixes #210
gaborcsardi added a commit that referenced this issue Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants