Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display build command #139

Merged
merged 1 commit into from
May 21, 2022
Merged

Display build command #139

merged 1 commit into from
May 21, 2022

Conversation

hadley
Copy link
Member

@hadley hadley commented May 20, 2022

This makes it more consistent with rcmdcheck, which will improve the consistency of devtools::check() (PR incoming shortly)

@hadley hadley requested a review from gaborcsardi May 20, 2022 21:00
@hadley hadley mentioned this pull request May 20, 2022
Merged
gaborcsardi
gaborcsardi approved these changes May 21, 2022
View reviewed changes
Copy link
Member

@gaborcsardi gaborcsardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed.

@gaborcsardi gaborcsardi merged commit 80762db into main May 21, 2022
@gaborcsardi gaborcsardi deleted the show-build-command branch May 21, 2022 04:14
@gaborcsardi
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaborcsardi gaborcsardi gaborcsardi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hadley @gaborcsardi