Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need more solver heuristics #276

Open
gaborcsardi opened this issue Mar 15, 2022 · 1 comment
Open

Need more solver heuristics #276

gaborcsardi opened this issue Mar 15, 2022 · 1 comment
Labels
bug an unexpected problem or unintended behavior

Comments

@gaborcsardi
Copy link
Member

Cf. #96 (comment) and https://github.com/gaborcsardi/rgdal/runs/5552862022?check_suite_focus=true

  • We should eliminate source packages if they are the same version.
  • We should eliminate binary packages if they are the same version.

Let's see if anything else is needed.

@gaborcsardi gaborcsardi added the bug an unexpected problem or unintended behavior label Mar 15, 2022
@gaborcsardi
Copy link
Member Author

A bad case with the learnr package:

pkgload::load_all()
library(pillar)

options(
  repos = c(
    RSPM = "https://packagemanager.rstudio.com/all/latest",
    CRAN = "https://cloud.r-project.org"
  )
)

prop <- new_pkg_installation_proposal(
  "deps::../learnr",
  config = list(dependencies = TRUE, library = tempfile())
)
prop$resolve()
prop$solve()

gaborcsardi added a commit that referenced this issue Mar 16, 2022
Not a proper solution just yet, but a somewhat crude
heuristic that rules out old binary packages if there
is a newer available.

Issue is at #276.
gaborcsardi added a commit that referenced this issue Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug an unexpected problem or unintended behavior
Projects
None yet
Development

No branches or pull requests

1 participant