Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More heuristics for the slow solver #277

Merged
merged 1 commit into from
Mar 16, 2022
Merged

More heuristics for the slow solver #277

merged 1 commit into from
Mar 16, 2022

Conversation

gaborcsardi
Copy link
Member

Not a proper solution just yet, but a somewhat crude
heuristic that rules out old binary packages if there
is a newer available.

Issue is at #276.

Not a proper solution just yet, but a somewhat crude
heuristic that rules out old binary packages if there
is a newer available.

Issue is at #276.
@codecov-commenter
Copy link

Codecov Report

Merging #277 (7d13dd6) into main (7f22af9) will increase coverage by 0.06%.
The diff coverage is 84.00%.

@@            Coverage Diff             @@
##             main     #277      +/-   ##
==========================================
+ Coverage   70.06%   70.12%   +0.06%     
==========================================
  Files          54       54              
  Lines        5157     5182      +25     
==========================================
+ Hits         3613     3634      +21     
- Misses       1544     1548       +4     
Impacted Files Coverage Δ
R/solve.R 77.38% <84.00%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f22af9...7d13dd6. Read the comment docs.

@gaborcsardi gaborcsardi merged commit 8baa07b into main Mar 16, 2022
@gaborcsardi gaborcsardi deleted the fix/slow-solver branch March 16, 2022 12:49
gaborcsardi added a commit that referenced this pull request Mar 16, 2022
gaborcsardi added a commit to r-lib/pak that referenced this pull request Mar 16, 2022
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Apr 29, 2022
# pak 0.3.0

* pak functions that used to return tibbles return data frames now.
  While data frames and tibbles are very similar, they are not completely
  compatible. To convert the outputs of pak functions to tibbles call the
  `tibble::as_tibble()` function on them. If the pillar package is loaded,
  it improves the printing of the returned data frames.

  Relatedly, `pak::pak_install_extra()` installs pillar now, instead of tibble.

* pak now supports `file://` repositories.

* pak now uses HTTP 1.1 to download packages on Linux, in addition to macOS.
  This fixes HTTP issues with some servers (#358).

* New `?ignore-before-r` parameter to ignore optional dependencies that
  need a newer R version (r-lib/pkgdepends#243).

* New `?ignore` parameter to ignore an optional dependency.

* Allow specifying downstream package parameters with the `package=?param`
  syntax.

* `lockfile_install()` now works better for `any::` refs, and pak always
  install the version it has planned for.

* System requirement installation is now more robust and works for
  Unix shell expressions (#347).

* CRAN-like resolution is more robust now if a repository is missing
  the usual metadata.

* The lock file is pretty JSON now.

* pak now handles all version requirement types properly:
  '<', '<=', `==`, `>=`, `>`.

* The dependency solver now uses better heuristics and does not
  (effectively) freeze if multiple repositories have multiple versions of
  the same packages (e.g. RSPM and CRAN)
  (r-lib/pkgdepends#277)

# pak 0.2.1

No user visible changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants