The \name{} field in an Rd file shouldn't be used in the topic index (

#1586) Fixes #1576
r-lib · Mar 26, 2021 · 672b8fc · 672b8fc
1 parent 9a5a8f5
commit 672b8fc
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/NEWS.md b/NEWS.md
@@ -1,5 +1,9 @@
 # pkgdown (development version)
 
+* Automatic links to reference pages were generated incorrectly if the
+  `\name{}` entry in the `*.Rd` file didn't match the filename
+  (@dmurdoch, #1586).
+
 * New "Customize your pkgdown website" vignette (#1573).
 
 * Added extension points to make HTML widgets (and RGL in particular) work

diff --git a/R/context.R b/R/context.R
@@ -10,7 +10,8 @@ section_init <- function(pkg, depth, override = list(), .frame = parent.frame())
 
 local_options_link <- function(pkg, depth, .frame = parent.frame()) {
   article_index <- set_names(path_file(pkg$vignettes$file_out), pkg$vignettes$name)
-  topic_index <- invert_index(set_names(pkg$topics$alias, pkg$topics$name))
+  Rdname <- fs::path_ext_remove(pkg$topic$file_in)
+  topic_index <- invert_index(set_names(pkg$topics$alias, Rdname))
 
   withr::local_options(
     list(