The \name{} field in an Rd file shouldn't be used in the topic index
#1586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o it shouldn't be used for the topic_index.
|
Yes, it does, I've just tested it, and it's similar to |
maelle
reviewed
Mar 26, 2021
Co-authored-by: Maëlle Salmon <maelle.salmon@yahoo.se>
|
Looks like I got a bit confused between issues and repos here 😬 |
hadley
approved these changes
Mar 26, 2021
There was a problem hiding this comment.
Looks good, thanks! Can you please add a bullet to the top of NEWS.md? It should briefly describe the change and end with (@yourname, #issuenumber).
|
Thanks @dmurdoch! |
This was referenced May 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1576
The
topic_indexis documented here: https://github.com/r-lib/downlit/blob/e22f072cfeaf91fbe7c38aeabd351aaa184d36fd/R/topic-index.R#L2, to map "aliases to Rd file names (sans extension)". The\name{}field can differ, so it shouldn't be used here.This fixes r-lib/downlit#83 .