Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should H1 in articles be added to TOC #2004

Closed
maelle opened this issue Jan 10, 2022 · 3 comments · Fixed by #2006
Closed

Should H1 in articles be added to TOC #2004

maelle opened this issue Jan 10, 2022 · 3 comments · Fixed by #2006
Labels
articles ✍️ bug an unexpected problem or unintended behavior
Milestone

Comments

@maelle
Copy link
Collaborator

maelle commented Jan 10, 2022

Example https://github.com/maelle/blabla/blob/main/vignettes/blop.Rmd
Website https://maelle.github.io/blabla/articles/blop.html

It seems to be a regression as the TOC on https://dplyr.tidyverse.org/articles/base.html looks fine

@maelle
Copy link
Collaborator Author

maelle commented Jan 10, 2022

Current selection

$scope: $("main h2, main h3, main h4, main h5, main h6")

@maelle maelle mentioned this issue Jan 10, 2022
1 task
@DavisVaughan
Copy link
Member

I think this is also the reason for this issue tidyverse/tidytemplate#72

@hadley
Copy link
Member

hadley commented Jan 10, 2022

But you don't want "blop" added to the TOC?

hadley added a commit that referenced this issue Jan 10, 2022
@hadley hadley added this to the v2.0.2 milestone Jan 10, 2022
@hadley hadley added articles ✍️ bug an unexpected problem or unintended behavior labels Jan 10, 2022
hadley added a commit that referenced this issue Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
articles ✍️ bug an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants