Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On CI, error if missing articles from index #2055

Closed
hadley opened this issue Mar 7, 2022 · 5 comments · Fixed by #2118
Closed

On CI, error if missing articles from index #2055

hadley opened this issue Mar 7, 2022 · 5 comments · Fixed by #2118
Labels
deploy ✈️ feature a feature request or enhancement
Milestone

Comments

@hadley
Copy link
Member

hadley commented Mar 7, 2022

Like we currently do for .Rd topics.

@maelle
Copy link
Collaborator

maelle commented Mar 7, 2022

Sort of related #2025

@hadley hadley added feature a feature request or enhancement deploy ✈️ labels May 31, 2022
@hadley hadley added this to the v2.0.4 milestone May 31, 2022
hadley added a commit that referenced this issue Jun 9, 2022
* Error, regardless of whether we're on CI or not (#2055)
* New `check_pkgdown()` for lightweight check of validity (#2056).
hadley added a commit that referenced this issue Jun 9, 2022
* Error, regardless of whether we're on CI or not (Fixes #2055)
* New `check_pkgdown()` for lightweight check of validity (Fixes #2056).
@netique
Copy link

netique commented Aug 12, 2022

Actually, I was deliberately omitting one of the vignettes because for pkgdown site I have a version of it with large animated gifs that is .Rbuildignored for CRAN package and the "static" version is provided instead here. With this change, a missing vignette results in an error and the site build fails. I was wondering if this could be aslo solved by title: internal as it is the case for Reference.

@maelle
Copy link
Collaborator

maelle commented Aug 23, 2022

@netique what do you mean by "the "static" version is provided instead here"? Where is the GIF used if not on CRAN neither on pkgdown?

Beside I'd suggest opening a new issue with your feature request.

@netique
Copy link

netique commented Aug 24, 2022

@maelle Sorry, I went into too much detail irrelevant to the problem. The issue is that I am not able to deliberately ignore the vignette or article in the build process. It used to issue just a warning, now missing article from the index is an error and the page build fails.

@maelle
Copy link
Collaborator

maelle commented Sep 2, 2022

@netique Thanks! Would you mind opening a feature request then?

If you describe your use case (for instance, "vignette to appear on CRAN but nowhere else"), maybe someone can also suggest a workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy ✈️ feature a feature request or enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants