Allow to control abort on missing topics. #2025
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadley
reviewed
May 31, 2022
| @@ -1,5 +1,8 @@ | |||
| # pkgdown (development version) | |||
|
|
|||
| * Environment variable ABORT_ON_MISSING_TOPICS can be used to enable/disable | |||
There was a problem hiding this comment.
Can you suggest a slightly more generic name? I think we'll also want to apply this to articles (#2055). And maybe it should have a PKGDOWN_ prefix?
|
@maelle do you remember why we this was causing ropensci docs to fail? Was there another bug somewhere that caused the missing topics? Or should we just manually fix packages with invalid pkgdown.yml configs? |
That might be smarter indeed |
|
In that case, lets close this issue. I'm planning on making two other changes:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not change any default behavior, but allows us to enable this locally, or disable it on CI, if needed.