Incorrect highlighting of active navigation category

[aoles]

The highlighting of active navigation category on the top navbar at https://giscience.github.io/openrouteservice-r doesn't work for me as expected. In particular, when viewing the vignette "Get started" doesn't get highlighted, while when browsing the man pages both "Reference" and "Home" are set to active. Observed under pkgdown 1.0.0.9000.

[hadley]

Hmmmmm, I wonder why I don't see this in (e.g.) http://testthat.r-lib.org/news/index.html

[aoles]

Thanks @hadley! This minimal pkg reproduces the described behavior illustrated in the screens below.

Some observations:

• The missing highlighting appears to be related to the presence of the leaflet widget. Removing it from the vignette and recreating the website restores the highlighting of "Get started". This seems to be a general html widget problem not specific to leaflet, as I get he same behavior with DT::datatable(cars). EDIT: This appears to have been fixed recently in the development version of pkgdown on GitHub.

• The 🏠 icon remains to be always "on" unless the vignette containing a html widget is displayed, then the highlighting doesn't seem to work at all. EDIT: Still an issue in devel..

[jayhesselberth]

Rendered site: https://affectionate-edison-98885b.netlify.com/index.html

Home icon has sticky highlight behavior here, but doesn't on other sites (e.g. http://pkgdown.r-lib.org)

Edit: actually it seems stochastic, may just be a browser session issue.

[hadley]

There's definitely a bug in the logic in the js function — rather than highlighting all nav sections that match, we need to highlight the one nav that has the longest match. I see this (for example) when rendering the site locally.