Provide way to override homepage title and card description #1034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added stuff related to "og:description" too. I took the freedom to edit pkgdown's own config file, but could remove that edit of course. :-) |
maelle
changed the title
maelle
commented
May 20, 2019
| @@ -1,5 +1,7 @@ | |||
| # pkgdown 1.3.0.9000 (development version) | |||
|
|
|||
| * One can override the title and description of the homepage via the `title` and `description` fields in the home section of config (#957, @maelle). | |||
|
|
|||
There was a problem hiding this comment.
btw this is the issue number not PR number.
maelle
changed the title
|
@maelle have you completed work on this PR? |
jayhesselberth
changed the title
Yes I've stopped adding pieces and can now implement your feedback. 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cf #957
I'm unsure of where and how to best document this.