-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce BS version, move templates to a subfolder by version #1485
Conversation
Ultimately I'd still like to add a BS4 folder before merging, that'd be exactly the same as the BS3 folder. This way when I make a PR editing the BS4 templates, it'll be clear how they differ from the BS3 templates. Is there a better way? |
line better error message maybe better fix not x fix ws
85e3505
to
070e5b8
Compare
@hadley What's your take on
Before adding the BS4 templates as a copy of BS3 templates, #1487 could be merged (it'll be easier to document those if they exist for both Bootstrap versions, and it's an easy enough change?) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still think it makes sense to merge this, and then do another PR that adds the initial BS4 templates.
Ok I'll do that after this PR, and #1487 are merged |
Same as #1481 but from this repo to get a preview.