add templates meant to be overridden #1487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
these are only documented in the draft PR #1490, maybe they could be mentioned in "YAML config - template" of |
hadley
reviewed
Feb 12, 2021
|
Hmmm, the only reason not to do this for BS3 is to provide an additional carrot to push people to upgrade. But I think it'll make the documentation quite a lot more complex, and relatively few people will use it, so it's fine to implement for both BS3 and BS4. |
|
ok so I think no more changes are needed (unless it is not ok to wait until #1490 to have docs)? |
hadley
approved these changes
Feb 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moments the use of templates is not documented anywhere I think? Edit: it is, in https://pkgdown.r-lib.org/reference/build_site.html#yaml-config-template It'll be in #987 .
I think this change can happen in the original BS3 templates?
I can think of an use case for "in-header.html", not for the other ones but since bookdown has them it's probably useful. 🙂