-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add templates meant to be overridden #1487
Conversation
these are only documented in the draft PR #1490, maybe they could be mentioned in "YAML config - template" of |
Hmmm, the only reason not to do this for BS3 is to provide an additional carrot to push people to upgrade. But I think it'll make the documentation quite a lot more complex, and relatively few people will use it, so it's fine to implement for both BS3 and BS4. |
ok so I think no more changes are needed (unless it is not ok to wait until #1490 to have docs)? |
At the moments the use of templates is not documented anywhere I think? Edit: it is, in https://pkgdown.r-lib.org/reference/build_site.html#yaml-config-template It'll be in #987 .
I think this change can happen in the original BS3 templates?
I can think of an use case for "in-header.html", not for the other ones but since bookdown has them it's probably useful. 🙂