Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

define the topic names differently? #1577

Closed
wants to merge 2 commits into from
Closed

define the topic names differently? #1577

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b5a205
define the topic names differently?
maelle Mar 17, 2021
cc3cfee
move fix downstream
maelle Mar 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion R/package.r
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ package_topics <- function(path = ".", package = "pkgdown") {
funs <- purrr::map(rd, topic_funs)

tibble::tibble(
name = names,
name = fs::path_ext_remove(file_out),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant rather than changing this field, you should be changing the code that uses name to instead use file_out. Or is this data structure just passed to downlit?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

topics goes to pkg via

pkgdown/R/package.r

Line 64 in 95af5d4

topics = package_topics(pkg, package),

what's passed to downlit is

pkgdown/R/context.R

Line 13 in e1e46f2

topic_index <- invert_index(set_names(pkg$topics$alias, pkg$topics$name))
, I could change that instead 🤔

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is what the next commit does but it does not work, actually. (testing on usethis locally)

file_in = file_in,
file_out = file_out,
alias = aliases,
Expand Down