-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
define the topic names differently? #1577
Conversation
R/package.r
Outdated
@@ -133,7 +133,7 @@ package_topics <- function(path = ".", package = "pkgdown") { | |||
funs <- purrr::map(rd, topic_funs) | |||
|
|||
tibble::tibble( | |||
name = names, | |||
name = fs::path_ext_remove(file_out), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant rather than changing this field, you should be changing the code that uses name
to instead use file_out
. Or is this data structure just passed to downlit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is what the next commit does but it does not work, actually. (testing on usethis locally)
@@ -10,7 +10,7 @@ section_init <- function(pkg, depth, override = list(), .frame = parent.frame()) | |||
|
|||
local_options_link <- function(pkg, depth, .frame = parent.frame()) { | |||
article_index <- set_names(path_file(pkg$vignettes$file_out), pkg$vignettes$name) | |||
topic_index <- invert_index(set_names(pkg$topics$alias, pkg$topics$name)) | |||
topic_index <- invert_index(set_names(pkg$topics$alias, fs::path_ext_remove(pkg$topics$file_out))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not enough
Closing in favour of #1586. |
No description provided.