Add advice to use usethis::edit_pkgdown_config()
#2419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use pkgdown_config_href() when pkg is available. Recommend usethis::edit_pkgdown_config() otherwise.
olivroy
commented
Mar 15, 2024
| expect_snapshot(build_favicons(pkg)), | ||
| "Can't find package logo" | ||
| expect_snapshot(error = TRUE, | ||
| expect_output(build_favicons(pkg), "Building favicons") |
There was a problem hiding this comment.
For some reasons, cli_alert_*() are not shown in snapshot tests, hence the expect_output() here to capture the desired behavior. As you can see in the previous snapshot, there was nothing. #2470
There was a problem hiding this comment.
Hmmm. We should probably switch those to cli_inform(), just for consistency, but that can be a separate PR.
hadley
approved these changes
Apr 2, 2024
| expect_snapshot(build_favicons(pkg)), | ||
| "Can't find package logo" | ||
| expect_snapshot(error = TRUE, | ||
| expect_output(build_favicons(pkg), "Building favicons") |
There was a problem hiding this comment.
Hmmm. We should probably switch those to cli_inform(), just for consistency, but that can be a separate PR.
|
Thanks! |
SebKrantz
pushed a commit
to SebKrantz/pkgdown
that referenced
this pull request
Jun 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
pkgis not available within the functionsAdded a couple of
callto improve error messages as I saw them. Sorry the PR is not very focused. Sometimes it is hard to come back to it later...Also the many changes in snapshots are caused by the fact that
{.file }quotes in non-interactive, whilecli::style_hyperlink()doesn't.Addresses #2329