Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Better error messages for tag parsing failures #771
This attempts to fix #770
Please take a look at the way I am wrangling and passing
This did not break any existing tests, but I think it's perhaps a little more fragile than I'd like. I'd be happy for suggestions - maybe it's a good idea to create a
You shouldn't be passing them in
If I can give you some concrete advice are you interested in finishing this PR off?
Thanks for the tips! Here's what I will try to do:
Input file name
Instead of passing
I'll omit any use of
I'll merge all of the repeated code into a subfunction as best I can!
I've made changes that should resolve the comments you've brought up. There are two outstanding issues: