New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad Rd tags throw errors #891

Merged
merged 5 commits into from Nov 15, 2018

Conversation

Projects
None yet
2 participants
@jayhesselberth
Copy link
Collaborator

jayhesselberth commented Nov 14, 2018

Cleaned up version of #771. Closes #771.

jayhesselberth added some commits Nov 14, 2018

Bad Rd tags throw errors
Cleaned up version of #771. Closes #771.

@jayhesselberth jayhesselberth merged commit 33c0591 into master Nov 15, 2018

6 checks passed

codecov/patch 86.36% of diff hit (target 82.53%)
Details
codecov/project 82.66% (+0.12%) compared to 8a3f03c
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@hadley

This comment has been minimized.

Copy link
Member

hadley commented Nov 15, 2018

Would you mind also incorporating the feedback I made on that PR?

@jayhesselberth

This comment has been minimized.

Copy link
Collaborator Author

jayhesselberth commented Nov 16, 2018

I went through that PR carefully and have addressed your previous suggestions with this commit.

@jayhesselberth jayhesselberth deleted the rd-errors branch Nov 16, 2018

@hadley

This comment has been minimized.

Copy link
Member

hadley commented Nov 19, 2018

Ok, then I'll make some more changes locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment