Fix handling of long strings and symbols in highlight() #21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20
We implement
get_parse_data()
as an alternative togetParseDate(, includeText = NA)
for strings and symbols we consider the text from the parent if :
New behaviour:
Created on 2022-11-10 with reprex v2.0.2
There are still corner cases unfortunately, see below in the parse data how the expression combines children so cannot be used as is.
I didn't go through the rabbit hole for those, they're unlikely to be encountered in practice. we keep the previous behavior.
Created on 2022-11-10 with reprex v2.0.2