Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsing of test failures is slightly unclear #161

Closed
hadley opened this issue Sep 20, 2021 · 4 comments · Fixed by #162
Closed

Parsing of test failures is slightly unclear #161

hadley opened this issue Sep 20, 2021 · 4 comments · Fixed by #162
Labels
bug an unexpected problem or unintended behavior
Milestone

Comments

@hadley
Copy link
Member

hadley commented Sep 20, 2021

✓  Running ‘statsWrapper_tests.R’ [11s/12s] (23.7s)
E  Running ‘timeProjectedNetwork_tests.R’ (25.1s)
   Running the tests in ‘tests/statsWrapper_tests.R’ failed.

I think it should be something like this?

E  Running ‘statsWrapper_tests.R’ [11s/12s] (23.7s)
✓  Running ‘timeProjectedNetwork_tests.R’ (25.1s)
  
Running the tests in ‘tests/statsWrapper_tests.R’ failed.
@gaborcsardi
Copy link
Member

Is this on GHA? Can you link to the build?

@hadley
Copy link
Member Author

hadley commented Sep 20, 2021

It was a failing testthat revdep, but I made a minimal reprex at https://github.com/hadley/testfails

─  checking tests ...
✓  Running ‘a.R’
✓  Running ‘b.R’ (394ms)
E  Running ‘c.R’ (601ms)
   Running the tests in ‘tests/b.R’ failed.
   Complete output:
     > stop("error")
     Error: error
     Execution halted

So looking at more closely I think it should probably be:

─  checking tests ...
✓  Running ‘a.R’
✓  Running ‘b.R’ (394ms)
✓  Running ‘c.R’ (601ms)
E  Running the tests in ‘tests/b.R’ failed.
   Complete output:
     > stop("error")
     Error: error
     Execution halted

@gaborcsardi
Copy link
Member

Thanks!

@gaborcsardi gaborcsardi added the bug an unexpected problem or unintended behavior label Sep 20, 2021
@gaborcsardi gaborcsardi added this to the 2.0.0 milestone Sep 20, 2021
@gaborcsardi
Copy link
Member

Ah, the R CMD check output for tests is different when you are using --as-cran.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants