Skip to content

Commit

Permalink
Remove threads arg of install_deps()
Browse files Browse the repository at this point in the history
If `Ncpus` was also specified, that led to an error.
Closes #153.
  • Loading branch information
gaborcsardi committed Sep 10, 2018
1 parent d6784d8 commit 25ca7e1
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 10 deletions.
3 changes: 3 additions & 0 deletions NEWS.md
Expand Up @@ -3,6 +3,9 @@
* `install_github()`'s previously deprecated `username` argument has been
removed. (#142)

* `install_deps()`'s `threads` argument has been removed, use the `Ncpus`
argument instead (#153, #154)

# Development

* Remotes can be forced to use only its internal code by setting the
Expand Down
4 changes: 0 additions & 4 deletions R/install.R
Expand Up @@ -102,8 +102,6 @@ safe_build_package <- function(pkgdir, build_opts, dest_path, quiet, use_pkgbuil
#' Install package dependencies if needed.
#'
#' @inheritParams package_deps
#' @param threads Number of threads to start, passed to
#' \code{\link[utils]{install.packages}} as \code{Ncpus}.
#' @param ... additional arguments passed to \code{\link[utils]{install.packages}}.
#' @param build If \code{TRUE} build the pacakge before installing.
#' @param build_opts Options to pass to `R CMD build`.
Expand All @@ -112,7 +110,6 @@ safe_build_package <- function(pkgdir, build_opts, dest_path, quiet, use_pkgbuil
#' \dontrun{install_deps(".")}

install_deps <- function(pkgdir = ".", dependencies = NA,
threads = getOption("Ncpus", 1),
repos = getOption("repos"),
type = getOption("pkgType"),
...,
Expand All @@ -135,7 +132,6 @@ install_deps <- function(pkgdir = ".", dependencies = NA,
packages,
dependencies = dep_deps,
...,
Ncpus = threads,
quiet = quiet,
upgrade = upgrade,
build = build,
Expand Down
9 changes: 3 additions & 6 deletions man/install_deps.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 25ca7e1

Please sign in to comment.