Skip to content

Commit

Permalink
Clarify github_pull() documentation (#640)
Browse files Browse the repository at this point in the history
Co-authored-by: Jim Hester <james.f.hester@gmail.com>
  • Loading branch information
ms609 and jimhester committed Aug 17, 2021
1 parent 37f5c96 commit 3c03a91
Show file tree
Hide file tree
Showing 6 changed files with 18 additions and 8 deletions.
1 change: 1 addition & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

* Using `remote_package_name.git2r_remote` and `remote_package_name.xgit_remote`, http responses returning an invalid `DESCRIPTION` or that redirect to another page will now fallback to return `NA` instead of throwing an error when trying to parse the unexpected content (#628, @dgkf).
* Fix regex that breaks git protocol in `git_remote` (@niheaven #630).
* Clarify `github_pull()` documentation (@ms609 #640).

# remotes 2.4.0

Expand Down
6 changes: 4 additions & 2 deletions R/install-github.R
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
#' @examples
#' \dontrun{
#' install_github("klutometis/roxygen")
#' install_github("wch/ggplot2")
#' install_github("wch/ggplot2", ref = github_pull("142"))
#' install_github(c("rstudio/httpuv", "rstudio/shiny"))
#' install_github(c("hadley/httr@@v0.4", "klutometis/roxygen#142",
#' "r-lib/roxygen2@@*release", "mfrasca/r-logging/pkg"))
Expand Down Expand Up @@ -153,8 +153,10 @@ remote_metadata.github_remote <- function(x, bundle = NULL, source = NULL, sha =
#' Use as `ref` parameter to [install_github()].
#' Allows installing a specific pull request or the latest release.
#'
#' @param pull The pull request to install
#' @param pull Character string specifying the pull request to install
#' @seealso [install_github()]
#' @examples
#' github_pull("42")
#' @rdname github_refs
#' @export
github_pull <- function(pull) structure(pull, class = "github_pull")
Expand Down
6 changes: 4 additions & 2 deletions inst/install-github.R

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 4 additions & 2 deletions install-github.R

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion man/github_refs.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion man/install_github.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 3c03a91

Please sign in to comment.