Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make "type" less vulnerable to loss #304

Closed
jennybc opened this issue Feb 24, 2019 · 1 comment
Closed

Make "type" less vulnerable to loss #304

jennybc opened this issue Feb 24, 2019 · 1 comment

Comments

@jennybc
Copy link
Member

jennybc commented Feb 24, 2019 •
edited
Loading

The conclusion of the conversation represented by #300 (there and in slack) is that storing type as an attribute of these data frames is too brittle. The row subsetting and binding those data frames go through makes it hard to retain the attributes correctly. I'm closing that PR in deference to some larger rethinking of how type gets passed around.

Probably also what's going on in #291. That also seems like a case where the specific combination of packages to be installed from various sources was unlucky.
@jennybc jennybc mentioned this issue Feb 24, 2019
Closed
@batpigandme
Copy link
Contributor

Also occurs for deldir and polyclips (by way of trying to install ggforce):

#> Installing 2 packages: deldir, polyclip
#> Error in if (type == "binary") { : argument is of length zero

@kevinushey kevinushey mentioned this issue Mar 11, 2019
Closed
jimhester added a commit that referenced this issue Apr 9, 2019
@jimhester
Do not rely on the type or repos attribute
7a0e46b 
It is too fragile and gets removed when rbinding

Fixes #304
@jimhester jimhester mentioned this issue Apr 9, 2019
Merged
jimhester added a commit that referenced this issue Apr 9, 2019
@jimhester
Do not rely on the type or repos attribute
e603859 
It is too fragile and gets removed when rbinding

Fixes #304
@pat-s pat-s mentioned this issue Apr 10, 2019
Closed
jimhester added a commit that referenced this issue Apr 10, 2019
@jimhester
Do not rely on the type or repos attribute (#340)
84c10ee 
It is too fragile and gets removed when rbinding remotes together. This was previously masked because of the order of the rbind, but that was changed in 8419037 which exposed this bug.

FIxes #291
Fixes #304
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jennybc @batpigandme