Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "type" less vulnerable to loss #304

Closed
jennybc opened this issue Feb 24, 2019 · 1 comment
Closed

Make "type" less vulnerable to loss #304

jennybc opened this issue Feb 24, 2019 · 1 comment

Comments

@jennybc
Copy link
Member

jennybc commented Feb 24, 2019

The conclusion of the conversation represented by #300 (there and in slack) is that storing type as an attribute of these data frames is too brittle. The row subsetting and binding those data frames go through makes it hard to retain the attributes correctly. I'm closing that PR in deference to some larger rethinking of how type gets passed around.

Probably also what's going on in #291. That also seems like a case where the specific combination of packages to be installed from various sources was unlucky.

@batpigandme
Copy link
Member

batpigandme commented Feb 25, 2019

Also occurs for deldir and polyclips (by way of trying to install ggforce):

#> Installing 2 packages: deldir, polyclip
#> Error in if (type == "binary") { : argument is of length zero

jimhester added a commit that referenced this issue Apr 9, 2019
It is too fragile and gets removed when rbinding

Fixes #304
jimhester added a commit that referenced this issue Apr 9, 2019
It is too fragile and gets removed when rbinding

Fixes #304
jimhester added a commit that referenced this issue Apr 10, 2019
It is too fragile and gets removed when rbinding remotes together. This was previously masked because of the order of the rbind, but that was changed in 8419037 which exposed this bug.

FIxes #291
Fixes #304
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants