Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bitbucket dependencies should use credentials from environment variables #347

Closed
antoine-sachet opened this issue Apr 10, 2019 · 0 comments · Fixed by #348
Closed

Bitbucket dependencies should use credentials from environment variables #347

antoine-sachet opened this issue Apr 10, 2019 · 0 comments · Fixed by #348

Comments

@antoine-sachet
Copy link
Contributor

antoine-sachet commented Apr 10, 2019

When creating a bitbucket_remote, the default user and password should be fetched from the environment variables. This is consistent with the current behaviour of github_remote or gitlab_remote which respectively use auth_token = github_pat() and auth_token = gitlab_pat().

This is easily fixed in install-bitbucket.R by changing:

bitbucket_remote <- function(repo, ref = "master", subdir = NULL,
                             auth_user = NULL, password = NULL,
                             sha = NULL, host = "api.bitbucket.org/2.0", ...)

to:

bitbucket_remote <- function(repo, ref = "master", subdir = NULL,
                             auth_user = bitbucket_user(), password = bitbucket_password(),
                             sha = NULL, host = "api.bitbucket.org/2.0", ...)

In fact it should really have been part of PR #344 but I only noticed it now. Until this is fixed, there is no way to install a private bitbucket repository since credentials are no longer passed to dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant