Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git_remote fails to parse gitlab urls with git protocol #627

Closed
danhalligan opened this issue Jun 15, 2021 · 0 comments · Fixed by #630
Closed

git_remote fails to parse gitlab urls with git protocol #627

danhalligan opened this issue Jun 15, 2021 · 0 comments · Fixed by #630

Comments

@danhalligan
Copy link
Contributor

This behaviour has changed recently (since 2.3.0 for example).

Previous behaviour:

> remotes:::git_remote("git@gitlab.company.com:group/package.git")
$url
[1] "git@gitlab.company.com:group/package.git"

$subdir
NULL

$ref
NULL

...

Current behviour:

> remotes:::git_remote("git@gitlab.company.com:group/package.git")
$url
[1] "git"

$subdir
NULL

$ref
[1] "gitlab.company.com:group/package.git"

...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix regex that broke git@xxx in install-git niheaven/remotes
1 participant
@danhalligan