Fix regex that broke git@xxx
in install-git
#630
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regex that fixed in #603 breaks
git@xxx
by accident 😭It just try to handle
@xxx
asref
, change it from(?:(?<url>[^@]*))(?:@(?<ref>.*))?)
to(?<url>(?:git@)?[^@]*)(?:@(?<ref>.*))?
will fix the problem.After fix: