Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helpful message when build fails for long paths #178

Merged
merged 3 commits into from Oct 2, 2018

Conversation

Projects
None yet
3 participants
@gaborcsardi
Copy link
Member

commented Oct 2, 2018

On windows. Closes #84.

This is for the case when we call R CMD build directly. Otherwise this should be "fixed" in pkgbuild.

Show resolved Hide resolved R/install.R Outdated
Show resolved Hide resolved R/install.R Outdated
@codecov-io

This comment has been minimized.

Copy link

commented Oct 2, 2018

Codecov Report

Merging #178 into master will decrease coverage by 0.43%.
The diff coverage is 72.41%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #178      +/-   ##
=========================================
- Coverage   91.84%   91.4%   -0.44%     
=========================================
  Files          29      29              
  Lines        1875    1897      +22     
=========================================
+ Hits         1722    1734      +12     
- Misses        153     163      +10
Impacted Files Coverage Δ
R/install.R 89.69% <72.22%> (-4.14%) ⬇️
R/utils.R 83.14% <72.72%> (-2.32%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ceb2f18...b5a2cce. Read the comment docs.

@gaborcsardi

This comment has been minimized.

Copy link
Member Author

commented Oct 2, 2018

@jimhester done.

@jimhester
Copy link
Member

left a comment

LGTM

@gaborcsardi gaborcsardi merged commit c06f7f4 into master Oct 2, 2018

1 of 4 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
@gaborcsardi

This comment has been minimized.

Copy link
Member Author

commented Oct 2, 2018

@jimhester Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.