-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy over remotes vignette from devtools #198
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks pretty good to me, I had a few minor comments.
vignettes/dependencies.Rmd
Outdated
### Other sources | ||
|
||
All of the currently supported install sources are available, see the 'See | ||
Also' section in `?install` for a complete list. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this needs to be updated, as there is no ?install
help in remotes. Maybe just to ?install_github
as the other install functions are now in the package installation family.
```yaml | ||
Remotes: r-lib/httr@v0.4, | ||
klutometis/roxygen#142, | ||
r-lib/testthat@c67018fa4970 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should mention the @*release
syntax here as well? It is not very well known, I am not entirely positive it will even work with remotes actually...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it used to work, but yeah, it does not work now:
❯ install_github("r-lib/R6@*release")
Error in github_resolve_ref.github_release(meta$ref %||% ref, meta, auth_token) :
No releases found for repo r-lib/R6.
vignettes/dependencies.Rmd
Outdated
|
||
### Github | ||
|
||
Because github is the most commonly used unofficial package distribution in R, it's the default: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should probably use GitHub's preferred capitalization of GitHub.
vignettes/dependencies.Rmd
Outdated
Remotes: local::/pkgs/testthat | ||
|
||
# Gitorious | ||
Remotes: gitorious::r-mpc-package/r-mpc-package |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have Gitorious remotes anymore
Thanks for catching these! Fixing... |
OK, fixed, merging... |
No description provided.