Pass unnamed parameters to install_deps from install for more consistent behavior with unnamed parameters #402
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current code, unnamed parameters are not being passed and respected in install_deps while being respected in the safe_install_package itself. This leads to inconsistent behavior with unnamed parameters and how they are treated with regards to the package installation vs. the installation of the package dependencies.
I am not sure if the exclusion of the unnamed parameters being passed into install_deps was intentional. The documentation on the parameters does not seem to be explicit about this nuance so I suspect this was a bug.
For more context, here is our specific use case and why this change is important.
Happy to add more clarification if needed. Thank-you!