Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting of error messages #81

Closed
krlmlr opened this issue Apr 1, 2017 · 4 comments
Closed

Formatting of error messages #81

krlmlr opened this issue Apr 1, 2017 · 4 comments

Comments

@krlmlr
Copy link
Member

krlmlr commented Apr 1, 2017

rlang::as_function(list())
#> Error: Cannot convert objects of type `list` to `function`

Types should not be quoted: tidyverse/dplyr#2448 (comment).

@hadley
Copy link
Member

hadley commented Apr 1, 2017

Maybe should be Can't covert a list to a function?

@krlmlr
Copy link
Member Author

krlmlr commented Apr 1, 2017

I wonder how much of error.R in tidyverse/dplyr#2608 can actually move to rlang.

@lionel-
Copy link
Member

lionel- commented Apr 3, 2017

the advantage of quoting is that you don't have to deal with grammar. E.g. this would be weird: Cannot convert a environment to a integer.

@hadley
Copy link
Member

hadley commented Apr 3, 2017

@lionel- we could fix that with friendly_type_of(x, article = TRUE). Or even dropping the articles would be fine: Can't convert list to integer vector

lionel- added a commit to lionel-/rlang that referenced this issue Apr 11, 2017
lionel- added a commit to lionel-/rlang that referenced this issue Apr 11, 2017
lionel- added a commit to lionel-/rlang that referenced this issue Apr 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants