remove duplicated authors #1333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadley
reviewed
Apr 19, 2022
There was a problem hiding this comment.
Thanks for working on this!
Could you please also re-document (to update NAMESPACE) and add a bullet to the top of NEWS.md? It should briefly describe the change and end with (@yourname, #issuenumber).
R/rd-author.R
Outdated
| @@ -0,0 +1,7 @@ | |||
|
|
|||
| #' @export | |||
There was a problem hiding this comment.
Given how simple this is, I think you could could keep it in rd-markdown.R
There was a problem hiding this comment.
I agree this is quite simple, but rd-markdown.R has such homogenous content I felt bad to blemish it with this one.
Besides, all merge.xxx() functions belong in a specific rd-xxx.R file.
Are you sure you want me to put it in rd-markdown.R?
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in #1269, here is a PR to remove duplicated authors.
Learned a lot about R6 objects in the process, this was quite fun 😀
May I also suggest tweaking
format_collapse()so that you can change the collapsing string? I think a single\nwould be nicer informat.rd_section_author(). (I can make another PR for this one)