New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A formatter for p-values #145

Merged
merged 1 commit into from Jul 9, 2018

Conversation

Projects
None yet
2 participants
@larmarange
Contributor

larmarange commented Jul 6, 2018

cf. #144

@larmarange larmarange referenced this pull request Jul 6, 2018

Closed

a formatter for p-values #144

@larmarange

This comment has been minimized.

Contributor

larmarange commented Jul 6, 2018

Just a quick question: is it better to have an accuracy argument, consistent with number_format or would you prefer for this specific formatter a digits argument?

@larmarange larmarange force-pushed the larmarange:pvalue_format branch 3 times, most recently from 89a6cec to 240c6e7 Jul 6, 2018

@hadley

I definitely prefer accuracy()

#' custom_function <- pvalue_format(accuracy = .1, decimal.mark = ",")
#' custom_function(p)
pvalue_format <- function(accuracy = .001, decimal.mark = ".", add_p = FALSE) {
function(x) pvalue(

This comment has been minimized.

@hadley

hadley Jul 8, 2018

Member

Need to force the 3 arguments

@larmarange larmarange force-pushed the larmarange:pvalue_format branch from 240c6e7 to 123d6f3 Jul 9, 2018

@larmarange

This comment has been minimized.

Contributor

larmarange commented Jul 9, 2018

done

@hadley hadley merged commit 419236a into r-lib:master Jul 9, 2018

3 checks passed

codecov/patch 72% of diff hit (target 68.11%)
Details
codecov/project 68.2% (+0.09%) compared to a0f0da1
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hadley

This comment has been minimized.

Member

hadley commented Jul 9, 2018

Thanks!

@larmarange larmarange deleted the larmarange:pvalue_format branch Jul 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment