Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore bash (.sh) scripts? #487

Closed
skirmer opened this issue Mar 26, 2019 · 3 comments
Closed

Ignore bash (.sh) scripts? #487

skirmer opened this issue Mar 26, 2019 · 3 comments

Comments

@skirmer
Copy link

skirmer commented Mar 26, 2019

After linting a folder, I found that it had impacted my .sh files, which I think is not the desired effect. Am I right that styler should skip these? Specifically, it added a space before $ which made quite a bit of difference in the bash scripts. (Love the package, thank you for all the work that went into this!)
@skirmer
Copy link
Author

skirmer commented Mar 26, 2019

By the way, if my interpretation is correct, I'd be happy to submit a PR to fix it.

@skirmer skirmer closed this as completed Mar 26, 2019
@skirmer
Copy link
Author

skirmer commented Mar 26, 2019

Upon a second try, I can't actually seem to replicate the issue, so closing this. Sorry!

@lorenzwalthert
Copy link
Collaborator

No problem 😄. Note that #345, #344 are somewhat related. However, file with extensions other than R or Rmd should not ever be styled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lorenzwalthert @skirmer