don't re-indent function declarations with scope < "indention"

[lorenzwalthert]

Closes #303

[codecov-io]

Codecov Report

Merging #304 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #304      +/-   ##
==========================================
- Coverage   91.18%   91.17%   -0.02%     
==========================================
  Files          30       30              
  Lines        1373     1371       -2     
==========================================
- Hits         1252     1250       -2     
  Misses        121      121

Impacted Files	Coverage Δ
R/style_guides.R	96.66% <100%> (-0.06%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7fff7a...0780c41. Read the comment docs.

[krlmlr]

Thanks! Makes sense to me.

[krlmlr]

I'm not in love with the use of identity here, this sure doesn't help performance. Maybe allow NULL and filter out later with compact()? Need to use lst() instead of c().

The name for the list elements will be the full quoted expression, maybe change l. 138 above to wrap_if_else_multi_line_in_curly = if (strict) wrap_if_else_multi_line_in_curly else identity and likewise in other places?

[lorenzwalthert]

Ok, I like the idea with purrr::compact(), lst() and naming the arguments here and in other places.

[lorenzwalthert]

Should we use lst() as a default in an exported function at all?

[lorenzwalthert]

Unfortunately, there was an inconsistency in create_style_guide(), which is that all inputs are list of transformers, except initialize, which is just a function (and not a list of functions). Should we make a breaking API change here so we can map conveniently and have a more consistent API or not? I suggest we internally convert to a list and keep the API as is.

[krlmlr]

It looks more natural to accept a function for the initialize argument, but there may be use cases where a list of functions is helpful. Agree to keep the API and use lst() internally (and not in the default argument).

[lorenzwalthert]

Ok, agree.