Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't modify token for edge cases styler ignore #611

Merged
merged 5 commits into from
Feb 22, 2020
Merged

Don't modify token for edge cases styler ignore #611

merged 5 commits into from
Feb 22, 2020

Commits on Feb 22, 2020

  1. if an expression was cached, we and is to ignore, we must also keep i… 

    …t in stylerignore because the parse table will be shallow
    @lorenzwalthert
    lorenzwalthert committed Feb 22, 2020
    Configuration menu
    Copy the full SHA
    fd6dfff View commit details
    Browse the repository at this point in the history

  2. don't try to style cases with braces involved

    @lorenzwalthert
    lorenzwalthert committed Feb 22, 2020
    Configuration menu
    Copy the full SHA
    cd4ab2c View commit details
    Browse the repository at this point in the history

  3. Revert "if an expression was cached, we and is to ignore, we must als… 

    …o keep it in stylerignore because the parse table will be shallow"

Apparently this is not necessary.
This reverts commit fd6dfff.
    @lorenzwalthert
    lorenzwalthert committed Feb 22, 2020
    Configuration menu
    Copy the full SHA
    89fbeae View commit details
    Browse the repository at this point in the history

  4. make sure cache is always deactivated at end of testthat file where w… 

    …e activated it at some point. All tests that are not explicit cache tests should not use it.
    @lorenzwalthert
    lorenzwalthert committed Feb 22, 2020
    Configuration menu
    Copy the full SHA
    441160e View commit details
    Browse the repository at this point in the history

  5. less strict speed assumptions

    @lorenzwalthert
    lorenzwalthert committed Feb 22, 2020
    Configuration menu
    Copy the full SHA
    d7cf178 View commit details
    Browse the repository at this point in the history