Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconsider expect_snapshot_error() #1548

Closed
hadley opened this issue Jan 10, 2022 · 1 comment · Fixed by #1682
Closed

Reconsider expect_snapshot_error() #1548

hadley opened this issue Jan 10, 2022 · 1 comment · Fixed by #1682
Labels
documentation snapshot 📷
Milestone
3.1.5

Comments

@hadley
Copy link
Member

hadley commented Jan 10, 2022

Based on discussion in #1471. In particular do we want to show the code, perhaps as a part of 3.1 edition?
@jennybc jennybc mentioned this issue May 2, 2022
Merged
@dpprdan dpprdan mentioned this issue Jun 3, 2022
Closed
@hadley hadley added this to the 3.1.5 milestone Sep 19, 2022
@hadley
Copy link
Member Author

hadley commented Sep 20, 2022

I think we just want to steer people away from it generally.

hadley added a commit that referenced this issue Sep 20, 2022
@hadley
Snapshot documentation improvements
900e002 
Fixes #1548. Fixes #1629. Fixes #1649.
@hadley hadley mentioned this issue Sep 20, 2022
Merged
hadley added a commit that referenced this issue Sep 22, 2022
@hadley
Snapshot documentation improvements (#1682)
1c9947d 
Fixes #1548. Fixes #1629. Fixes #1649.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation snapshot 📷
Projects
None yet
Milestone
3.1.5
Development

Successfully merging a pull request may close this issue.

Snapshot documentation improvements r-lib/testthat
1 participant
@hadley