Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better handling for file snapshots #1546

Merged
merged 2 commits into from
Jan 9, 2022
Merged

Better handling for file snapshots #1546

merged 2 commits into from
Jan 9, 2022

Conversation

hadley
Copy link
Member

@hadley hadley commented Jan 8, 2022

Fixes #1545

@schloerke
Copy link
Contributor

✅ Works for me. Thank you!

@hadley
Copy link
Member Author

hadley commented Jan 8, 2022

I tweaked it slightly so to you now need a trailing / for directories. I assume that's not really a breaking change since most people will just copy and paste the hint.

@schloerke
Copy link
Contributor

just copy and paste the hint

💯

@hadley hadley merged commit 4b1b727 into main Jan 9, 2022
@hadley hadley deleted the meta-files branch January 9, 2022 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

snapshot_review() is not finding any files to review
2 participants
@hadley @schloerke