Adding equals_reference expectation, documentation and test #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (is.null(label)) { | ||
| label <- paste("reference from", file) | ||
| } | ||
| equals(reference, label=label, ...) |
There was a problem hiding this comment.
Could you put spaces around = please?
|
Looks good - only thing missing is a bullet point in NEWS.md |
|
Ah yes, missed that - sorry. I'll push that and the other tweaks shortly. Shall I create a "new expectations" section in NEWS.md, as for the 0.8 release, or just fold it into "new features" for 0.9? |
|
Just fold into new features. |
hadley
added a commit
that referenced
this pull request
Sep 18, 2014
Adding equals_reference expectation, documentation and test
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses issue #148. I have called the new expectation
equals_reference, as suggested.