Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow symlinks when grabbing GHA workflows #1483

Closed
jennybc opened this issue Sep 13, 2021 · 1 comment · Fixed by #1509
Closed

Follow symlinks when grabbing GHA workflows #1483

jennybc opened this issue Sep 13, 2021 · 1 comment · Fixed by #1509
Labels
git git, GitHub, and CI in general

Comments

@jennybc
Copy link
Member

jennybc commented Sep 13, 2021

https://docs.github.com/en/rest/reference/repos#if-the-content-is-a-symlink

If we did this instead of naive URL/file grab, @jimhester could go back to using symlinks in https://github.com/r-lib/actions
@jimhester
Copy link
Member

Another thing we might want to do if we do this is to pull the files from the v1 tag rather than from HEAD.

This would ensure users get the stable workflows rather than something that is still in flux.

I generally try to be careful about testing workflow changes in branches before merging them to HEAD, but having an extra layer of guarantees around this is probably good.

@jennybc jennybc added the git git, GitHub, and CI in general label Sep 28, 2021
@jennybc jennybc added this to the v2.1.0 milestone Sep 28, 2021
@jennybc jennybc mentioned this issue Sep 28, 2021
Closed
@jennybc jennybc mentioned this issue Oct 6, 2021
Merged
jennybc added a commit that referenced this issue Oct 6, 2021
@jennybc
Use use_github_file() in use_github_action()
ea05f91 
Closes #1483
jennybc added a commit that referenced this issue Oct 7, 2021
@jennybc
Add use_github_file() and use it in use_github_action*() (#1509)
7c427e6 
* Add use_github_file()

Closes #1407

* Comment not needed now

* Add tests

* Avoid lazy quantifier

* Note a GHE (maybe) TODO

* Support URL parsing for GHE

* Add more real-but-unsupported URLs

* NEWS bullet

* Use use_github_file() in use_github_action()

Closes #1483

* Add more to NEWS bullet

* Mention use_github_file() in use_github_action()

* Use use_github_file() here

* Replace some `master` with `HEAD`

* Work on docs

* Update snapshot test

* Comma

* Target tag 'v1' in r-lib/actions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
git git, GitHub, and CI in general
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add use_github_file() and use it in use_github_action*() r-lib/usethis
2 participants
@jimhester @jennybc