Skip to content

Add use_github_file() and use it in use_github_action*()#1509

Merged
jennybc merged 17 commits intomasterfrom
use_github_file
Oct 7, 2021
Merged

Add use_github_file() and use it in use_github_action*()#1509
jennybc merged 17 commits intomasterfrom
use_github_file

Conversation

@jennybc
Copy link
Member

@jennybc jennybc commented Oct 6, 2021

Closes #1407, closes #1483

@jennybc jennybc requested a review from jimhester October 6, 2021 06:07
@jennybc
Copy link
Member Author

jennybc commented Oct 6, 2021

@jimhester I haven't wired this up to the GHA functions yet, but that's next. If you have any observations, please share. Or wait 'til this is more done.

@jennybc jennybc requested a review from malcolmbarrett October 6, 2021 06:08
@jennybc
Copy link
Member Author

jennybc commented Oct 6, 2021

@malcolmbarrett Is this what you had in mind?

Copy link
Collaborator

@malcolmbarrett malcolmbarrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and works great so far! Presumably, you'll refactor use_github_action() to use use_github_file() internally?

@jennybc jennybc marked this pull request as ready for review October 6, 2021 22:27
@jennybc
Copy link
Member Author

jennybc commented Oct 6, 2021

OK @jimhester this is ready for another look. I'm going to call your attention to a few things.

Once this is merged and, presumably, released, you could go back to using symlinks in r-lib/actions.

Copy link
Member

@jimhester jimhester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if we change all the current references to master to HEAD then this should be good to go.

@jennybc
Copy link
Member Author

jennybc commented Oct 7, 2021

@jimhester Yes, I just confirmed that HEAD works as the ref everywhere we discuss above.

But from #1483 I got the impression that maybe you wanted to use v1, the same way we're using that as the ref in the actual workflows. It does have a pleasing self-consistency to it.

@jimhester
Copy link
Member

That is right, I think using v1 makes sense, lets do that.

@jennybc
Copy link
Member Author

jennybc commented Oct 7, 2021

That is right, I think using v1 makes sense, lets do that.

I think it also makes your mental management of the v1 tag easier, if we aren't pulling workflow yaml from HEAD but then, in that same yaml, pulling actual GHA components from v1.

Resolved: I'm going to make v1 the target ref for anything we're pulling out of r-lib/actions.

@jennybc jennybc changed the title Add use_github_file() Add use_github_file() and use it in use_github_action*() Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Follow symlinks when grabbing GHA workflows Generalizing use_github_action() with use_github_file()

3 participants