-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use_git_config() behavior inconsistent with article #668
Comments
Upon further consideration, I suspect a "culprit" is the |
@ijlyttle I think this is an intended change as it is documented in the NEWS file for the current dev version.
and it is in place since since bbc6b47 also documented Line 105 in f08ecb6
Before that, yes this function was returning visibly all the time for user name and email only Lines 132 to 133 in a4c0113
now it returns invisibly only the modified values. I guess only |
Yes I'd appreciate a change to the setup vignette. Note that I just pushed a bit of a update to that document myself. But I didn't touch this stuff. |
* Fix #668 by including git_sitrep() in setup article * Remove stray space
Edit: I did not look at this carefully enough; as @cderv points out, this is very likely a documentation issue.
As best as I can tell, this was working in usethis 1.4.0:
usethis/vignettes/articles/usethis-setup.Rmd
Lines 72 to 73 in f08ecb6
I updated one of my machines to the dev version, and it returns without printing anything to the screen.
The operative code in usethis seems to be in an internal function
git_config()
, which then callsgit2r::config()
:usethis/R/git-utils.R
Lines 297 to 310 in 37a774e
When I updated my usethis, it updated git2r 0.24.0 -> 0.25.2
Happy to dig further, but wanted to surface this now in case you had some ideas already.
Thanks!
The text was updated successfully, but these errors were encountered: